Remove core imports from dbt.artifacts component #9694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9694 +/- ##
=======================================
Coverage 88.08% 88.08%
=======================================
Files 178 180 +2
Lines 22459 22457 -2
=======================================
Hits 19782 19782
+ Misses 2677 2675 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MichelleArk
added
the
artifact_minor_upgrade
MichelleArk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves ##9926
Problem
Non dbt.artifacts imports from dbt.* in dbt/artifacts represent circular dependencies if dbt/artifacts were to be pulled out as a standalone package from dbt-core.
Solution
This PR is best to review commit-by-commit!
Remove as many dbt.* core imports as possible in this PR. This has included:
Outstanding dependencies:
These are going to be a higher lift and I'd like to tackle them in a follow-on to prevent this PR from getting too large in scope.
Checklist